Fix undefined problems with browser defined objects #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muaz-khan
added a commit
that referenced
this pull request
Oct 5, 2015
|
Thanks for merging the PR in! I'll close this. |
|
Reopening since you have forgotten to also add https://github.com/muaz-khan/RecordRTC/pull/45/files#diff-6c74f5278517d57b7ec3f125cc5b0c6dR55 Because of this we get |
Closed
|
Maybe already merged. |
AndersDJohnson
pushed a commit
to AndersDJohnson/RecordRTC
that referenced
this pull request
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also related to #44
The existing code is problematic in browsers that have AudioContext, MediaStream, requestAnimationFrame unprefixed.
Using
is wrong because of hoisting, so at the time of the
ifcheck, the variable is undefined.