Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RecordRTC.Storage in StereoAudioRecorder #504

Merged
merged 2 commits into from Feb 26, 2020

Conversation

xcloarec
Copy link

@xcloarec xcloarec commented Apr 5, 2019

Use RecordRTC.Storage in StereoAudioRecorder to allow context close within RecordRTC.destroy()

This solve the issue #495

@AlexeyBatrachenko
Copy link

Hey @xcloarec, @muaz-khan
Could you please resolve all issues and merge this into master? Is there anything that I can do to get it merged?
Unfortunately, we have to use a fork with these changes instead of the master branch to provide correct behavior for Safari.

@xcloarec
Copy link
Author

Hi @AlexeyBatrachenko , issue is because continous integration is failing since a long time. Mee too I can't do anynthing more but wait for this pull-request to be merged or commented by @muaz-khan .

@jamauro
Copy link

jamauro commented Jul 29, 2019

@muaz-khan any plans to merge this or offer an alternative solution?

@muaz-khan
Copy link
Owner

@jamauro Maybe we should try window.Storage instead?

E.g. (dev/StereoAudioRecorder.js line no. 404)

if (typeof window.Storage === 'undefined') {
    window.Storage = {
        AudioContextConstructor: null,
        AudioContext: window.AudioContext || window.webkitAudioContext
    };
}

Actually I want to keep StereoAudioRecorder as a standalone library. If we use RecordRTC.Storage then it starts depending on RecordRTC.

@jamauro
Copy link

jamauro commented Jul 29, 2019

@muaz-khan thanks for the quick follow up. your approach sounds fine to me.

Actually I want to keep StereoAudioRecorder as a standalone library. If we use RecordRTC.Storage then it starts depending on RecordRTC.

👍 makes sense

MaciejKus pushed a commit to MaciejKus/RecordRTC that referenced this pull request Nov 15, 2019
@muaz-khan muaz-khan merged commit 0d617d0 into muaz-khan:master Feb 26, 2020
muaz-khan added a commit that referenced this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants