[Bug] 'Report a bug' in Menu sometimes has icon, most often it doesn't

[pskowronek]

Is there an existing issue for this?

• I have searched the existing issues (including the closed ones)

Description

Report a bug' in Menu sometimes has icon, most often it doesn't.

Very strange :)

Steps to reproduce

Open muCommander and navigate to Menu -> Help - observe whether 'Rpeort a bug' has an icon.
Re-launch muCommander a couple of times - sometimes it has it, sometimes not - most often it doesn't have it.

Expected behavior

Consistent display of that icon.

Actual behavior

Randomness.

Screenshots?

It is when it has it:

muCommander version

1.4.0, in 1.3.0 I don't see this icon either.

Java version

as provided by DMG

Operating System type and version

macOS Ventura (OCLP)

Relevant log output

No response

[pskowronek]

This is caused by Menu item and Tool bar items being loaded in simultaneously in parallel here:

mucommander/mucommander-core/src/main/java/com/mucommander/ui/main/MainFrame.java

Lines 199 to 210 in eb26d7a

	executor.execute(() -> {
	this.toolbar = new ToolBar(this);
	this.toolbarPanel = ToolbarMoreButton.wrapToolBar(toolbar);
	this.toolbarPanel.setVisible(MuConfigurations.getPreferences().getVariable(MuPreference.TOOLBAR_VISIBLE, MuPreferences.DEFAULT_TOOLBAR_VISIBLE));
	contentPane.add(toolbarPanel, BorderLayout.NORTH);
	});
	executor.execute(() -> {
	// Create menu bar (has to be created after toolbar) - ok, but why?
	MainMenuBar menuBar = new MainMenuBar(this);
	getJFrame().setJMenuBar(menuBar);
	});

The following line nullifies icons in Menu, but apparently it can be overridden by Toolbar loading thread (still I'm not sure how/why tho...):

mucommander/mucommander-commons-util/src/main/java/com/mucommander/commons/util/ui/helper/MenuToolkit.java

Line 194 in eb26d7a

menu.add(menuItem);

When this line is commented out, then Menu contains pretty nice icons in the menu - the question is whether such UX we would like to have: