Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Erratic behavior #1179

Closed
1 task done
Andreas0602 opened this issue May 8, 2024 · 15 comments · Fixed by #1181
Closed
1 task done

[Bug] Erratic behavior #1179

Andreas0602 opened this issue May 8, 2024 · 15 comments · Fixed by #1181
Labels
Milestone

Comments

@Andreas0602
Copy link

Andreas0602 commented May 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues (including the closed ones)

Description

Please see the attached video.

Bug 1 (at 00′12″ in the video): All main menu items except "muCommander" are missing. When changing from the Downloads directory in the left pane to the root directory in the right pane, the missing menu items appear.

Bug 2 (at 00′41″ in the video): When switching to "Custom folder", the appearance changes undesirably from FlatLaf to CDE/Motiv. FlatLaf is unavailable.

Log file: removed

Demo.mp4

Steps to reproduce

Expected behavior

Actual behavior

Screenshots?

No response

muCommander version

Version: 1.5.0
Build date: 2024/05/08
Build number: 54524da

Java version

Runtime version: 23-internal
VM name: OpenJDK 64-Bit Server VM
VM version: 23-internal-ahadas-0081ac197a656cdc0d88d5a5e2a0f399ee023654
VM vendor: Oracle Corporation

Operating System type and version

Name: Mac OS X
Version: 14.4.1
Architecture: aarch64

Relevant log output

No response

@Andreas0602 Andreas0602 added the bug label May 8, 2024
@pskowronek
Copy link
Member

(@Andreas0602 - that video is in terrible format, I'm having a problem watching it both in Firefox and VLC - it looks like nothing happens until you scroll and only then the video content gets updated)

@Andreas0602
Copy link
Author

It's a mp4 file encoded with H.264 ... should be quite a common format. Anyway, I've just converted it to webm VP8 with a reduced resolution of 1920 x 1080. How about that one?

Demo.webm

@pskowronek
Copy link
Member

It's a mp4 file encoded with H.264 ... should be quite a common format. Anyway, I've just converted it to webm VP8 with a reduced resolution of 1920 x 1080. How about that one?
Demo.webm

H.264 but something wasn't good in it. This one works great.

@pskowronek
Copy link
Member

@Andreas0602 ad Bug 2 - do you reproduce that always? Is it only for Downloads or for other folders you have the same problem?

@Andreas0602 Andreas0602 changed the title [Bug] Erratic behavior related to Download folder [Bug] Erratic behavior May 8, 2024
@Andreas0602
Copy link
Author

I reproduce bug 2 always. And it happens for all folders. Therefore, I've just changed the title of this issue to "Erratic behavior".

@pskowronek
Copy link
Member

I cannot produce bug 2. Could you change log level to finest and provide logs? Maybe this will give us some hint.

@pskowronek
Copy link
Member

ad bug 1 - do you reproduce that always or randomly?

@Andreas0602
Copy link
Author

Andreas0602 commented May 8, 2024

Bug 1 occurs randomly.

Here is the log file from bug 2 with finest level: removed

@pskowronek
Copy link
Member

pskowronek commented May 8, 2024

ad bug 1 - I'm able to reproduce using debugger

ad bug 2 - I don't see anything obvious (you may remove the recent log above now as it contains some internal IPs and names). I set the same L&F and still nothing. However, I see this in your logs:

2024-05-08 22:53:32.270 [WT-EventQueue-0] DEBUG com.mucommander.ui.theme.ThemeReader:934 - Unexpected start of element executable, ignoring.                     
2024-05-08 22:53:32.270 [WT-EventQueue-0] DEBUG com.mucommander.ui.theme.ThemeReader:158 - Ignoring element: normal                                              
2024-05-08 22:53:32.270 [WT-EventQueue-0] DEBUG com.mucommander.ui.theme.ThemeReader:158 - Ignoring element: selected                                            
2024-05-08 22:53:32.270 [WT-EventQueue-0] DEBUG com.mucommander.ui.theme.ThemeReader:934 - Unexpected start of element file_groups, ignoring.                    
2024-05-08 22:53:32.270 [WT-EventQueue-0] DEBUG com.mucommander.ui.theme.ThemeReader:158 - Ignoring element: group1

I don't see anything similar in my logs. So, I have a hunch that it might be somehow related to Custom theme you have there. Can you open theme by Edit (you may first export it and provide it here):

obraz

This tells me, that probably changing anything in preferences might trigger defaulting to CDE/Motif - have you checked that?

@Andreas0602
Copy link
Author

ad bug 1 - I'm able to reproduce using debugger

Good.

you may remove the recent log above now

Thanks for the hint. Done.

Can you open theme by Edit

Yes, I can.

you may first export it and provide it here

Here it is: exported_theme.zip

@Andreas0602
Copy link
Author

Andreas0602 commented May 8, 2024

Update on bug 2: The bug occurs whenever changing any preference (e.g. Time: 24-hour format -> 12-hour format) and then clicking the Apply button. So, your guess was right.

@pskowronek
Copy link
Member

pskowronek commented May 8, 2024

After importing your theme I can reproduce the behavior:
obraz

@pskowronek
Copy link
Member

After importing your theme I can reproduce the behavior:

But only once and no more :)

@pskowronek
Copy link
Member

ad bug 1 - the problem is caused by menu items being constructed in the background for a faster muC launch. The JFrame was not "revalidated" after updating the menu items. Fix on the way.

ad bug 2 - the problem was kinda race condition caused by loading additional L&Fs in the background (deferred loading) for a faster muC launch. When Preferences were opened and L&Fs loading finished just after that, the L&Fs dropdown was in unstable condition. The bug has nothing to do with custom theme etc. Fix on the way.

pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue May 9, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue May 9, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue May 11, 2024
@ahadas ahadas linked a pull request May 13, 2024 that will close this issue
@ahadas ahadas added this to the 1.4.1 milestone May 14, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue May 14, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue May 14, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue May 30, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue May 30, 2024
@ahadas
Copy link
Member

ahadas commented Jun 12, 2024

Version 1.4.1 that includes a fix for this issue has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants