Handle duplicated names in a stage #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to kairos-io/kairos#2488 Signed-off-by: Mauro Morales <contact@mauromorales.com>
Itxaka
approved these changes
Apr 26, 2024
| prev := "" | ||
| for i, st := range currentStages { | ||
| name := st.Name | ||
| if duplicatedNames { |
There was a problem hiding this comment.
Do we actually need to check or can we skip that and just add that index always and call it a day?
There was a problem hiding this comment.
@Itxaka yeah that was my first approach. I went with this because otherwise if you want to reference a step by name, you have to know in which position it will end. Thankfully there was a test so I saw this problem:
https://github.com/mudler/yip/blob/master/pkg/executor/default_test.go#L226
would need to be referenced as test.0 which would be very confusing, specially if some step gets introduced before the wanted one
davidcassany
pushed a commit
to davidcassany/yip
that referenced
this pull request
Jul 3, 2024
(cherry picked from commit 9394813)
kkaempf
pushed a commit
to rancher/yip
that referenced
this pull request
Jul 3, 2024
* Set the vfat label using the correct flag (mudler#141) -i expects a hexadecimal value -n should be used for the filesystem label https://man7.org/linux/man-pages/man8/mkfs.vfat.8.html Needed as part of kairos-io/kairos#2281 so that this config: ``` add_partitions: - fsLabel: COS_GRUB size: 64 pLabel: efi filesystem: "fat" ``` won't result in this error: ``` Volume ID must be a hexadecimal number ``` Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> (cherry picked from commit 4ebbc75) * Reuse existing user id if it exists (mudler#145) (cherry picked from commit 9484451) * Handle duplicated names in a stage (mudler#147) (cherry picked from commit 9394813) --------- Co-authored-by: Dimitris Karakasilis <jimmykarily@gmail.com> Co-authored-by: Itxaka <itxaka.garcia@spectrocloud.com> Co-authored-by: Mauro Morales <contact@mauromorales.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to kairos-io/kairos#2488
description on the issue can be found on the ticket mentioned above