Reuse existing user id if it exists #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We dont want to fully skip the user update if it exists as it may be for a specific reason like updating groups and such, but if the entry does not have a specific user id set by the user object and the user already exists in the passwd file, we should reuse the userid as to not break existing files that may have permissions linked to that user This should fix: - users in config files appearing more than once, so their uid wont change - ssh keys added to users than are updated after the key creation - anything else adding a user to the passwd file and bumping the next uid free, as our calculation picks the latest free uid Signed-off-by: Itxaka <itxaka@kairos.io>
mauromorales
approved these changes
Apr 22, 2024
- Provide a proper /etc/passwd with normal lines instead of empty - Check that the user management does not remove existing users - Rework the test to deal with the extended passwd file - Add tests for maintaining the UID of an user Signed-off-by: Itxaka <itxaka@kairos.io>
Itxaka
force-pushed
the
reuse-exiting-uid
branch
from
d7123eb
to
f265c87
Compare
mauromorales
approved these changes
Apr 22, 2024
davidcassany
pushed a commit
to davidcassany/yip
that referenced
this pull request
Jul 3, 2024
(cherry picked from commit 9484451)
kkaempf
pushed a commit
to rancher/yip
that referenced
this pull request
Jul 3, 2024
* Set the vfat label using the correct flag (mudler#141) -i expects a hexadecimal value -n should be used for the filesystem label https://man7.org/linux/man-pages/man8/mkfs.vfat.8.html Needed as part of kairos-io/kairos#2281 so that this config: ``` add_partitions: - fsLabel: COS_GRUB size: 64 pLabel: efi filesystem: "fat" ``` won't result in this error: ``` Volume ID must be a hexadecimal number ``` Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> (cherry picked from commit 4ebbc75) * Reuse existing user id if it exists (mudler#145) (cherry picked from commit 9484451) * Handle duplicated names in a stage (mudler#147) (cherry picked from commit 9394813) --------- Co-authored-by: Dimitris Karakasilis <jimmykarily@gmail.com> Co-authored-by: Itxaka <itxaka.garcia@spectrocloud.com> Co-authored-by: Mauro Morales <contact@mauromorales.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont want to fully skip the user update if it exists as it may be for a specific reason like updating groups and such, but if the entry does not have a specific user id set by the user object and the user already exists in the passwd file, we should reuse the userid as to not break existing files that may have permissions linked to that user
This should fix: