upgrade MDL-20933 Fixed warning if get_records_sql returned false rat…

…her than an array
mudrd8mz · Nov 24, 2009 · f544529 · f544529
1 parent a27c35d
commit f544529
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
@@ -3264,9 +3264,10 @@ function xmldb_main_upgrade($oldversion=0) {
                        AND u.deleted = 0
                        AND rc.contextid = ".$systemcontext->id." AND u.auth<>'manual' AND u.auth<>'email'";
 
-        $adminusers = get_records_sql($sql);
-        foreach ($adminusers as $adminuser) {
-            delete_records('user_preferences', 'userid', $adminuser->id, 'name', 'auth_forcepasswordchange');
+        if ($adminusers = get_records_sql($sql)) {
+            foreach ($adminusers as $adminuser) {
+                delete_records('user_preferences', 'userid', $adminuser->id, 'name', 'auth_forcepasswordchange');
+            }
         }
         unset($adminusers);