Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash and python2 for CMD bee usage in docker images #330

Closed
wants to merge 3 commits into from
Closed

Add bash and python2 for CMD bee usage in docker images #330

wants to merge 3 commits into from

Conversation

rocket357
Copy link

The default beehive docker image shell (busybox) leaves a lot to be desired when it comes to executing commands via the CMD hive. This PR adds bash and python2 to the installed packages to allow them to be used in CMD.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.919% when pulling b7b2ac8 on rocket357:master into d22455f on muesli:master.

@rocket357 rocket357 changed the title Add bash and python2 for CMD hive usage Add bash and python2 for CMD hive usage in docker images Aug 26, 2020
@rocket357 rocket357 changed the title Add bash and python2 for CMD hive usage in docker images Add bash and python2 for CMD bee usage in docker images Aug 26, 2020
@rocket357
Copy link
Author

rocket357 commented Sep 1, 2020

There is a "bit" of size difference (as expected):

root@beehive:~# docker image list | grep beehive
beehive latest b70912e0ab24 6 days ago 71.7MB
fribbledom/beehive latest 4c5db390fbc9 2 weeks ago 33.5MB

@muesli
Copy link
Owner

muesli commented Oct 3, 2020

I'm a bit torn on this one. Bash probably makes sense, but where do we draw the line with regards to python?

@rocket357
Copy link
Author

rocket357 commented Oct 3, 2020 via email

@muesli
Copy link
Owner

muesli commented Oct 3, 2020

Yeah, python is quite arbitrary (both version and python itself), and is included here because my specific requirement is for python2, and not, say, ruby. Would it make more sense to write up documentation on customizing the docker image, or perhaps providing both a minimal and a "kitchensink" docker image?

I like both these ideas a lot!

@rocket357
Copy link
Author

Is there a way to gather metrics (automated preferably, but a poll of beehive users would work, too, if not) to see what everyone is using with command bees? If polling, do you have preferences on how/who/when/etc...?

Add an optional layer for additional cmd bee scripting languages/tools
@rocket357
Copy link
Author

Side note: Seeing build/test (1.15.x ubuntu-latest) fail with:

Error: bees/notificationbee/notificationbee_unix.go:43:19: conversion from uint32 to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

@rocket357
Copy link
Author

First run test image (currently testing on my kubernetes cluster):

https://hub.docker.com/r/rocket357/beehive-kitchensink

Based on:

https://github.com/rocket357/beehive-kitchensink/blob/main/Dockerfile

Perhaps we can configure a separate branch to automate building on Dockerhub? That may introduce some sync issues on the github side. Any ideas on how best to tackle getting a separate Dockerfile into fribbledom/beehive official? We could use a sub folder in github and build rules on Dockerhub to automate, I suppose.

@rocket357
Copy link
Author

Since dockerhub has removed build automation for free accounts, I've set up a build server to automate building the beehive-kitchensink images (available here). I've removed python2 since it is well into EOL and I'm building multi-arch images (currently arm32v7, arm64v8, and amd64).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants