Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide show mount point #107

Merged
merged 23 commits into from Apr 21, 2021
Merged

Hide show mount point #107

merged 23 commits into from Apr 21, 2021

Conversation

IGLOU-EU
Copy link
Contributor

Fix #101

@luckman212
Copy link

Possible to add wildcard support?

duf -hide-mp '/Volumes/.timemachine*'

or

duf -only-mp '/System/Volumes/*'

@IGLOU-EU
Copy link
Contributor Author

Hi @luckman212
this is a good idea, I can do that.

@IGLOU-EU IGLOU-EU changed the title Adrien/hide show mount point WIP hide show mount point Feb 24, 2021
@IGLOU-EU IGLOU-EU changed the title WIP hide show mount point Hide show mount point Mar 27, 2021
@IGLOU-EU
Copy link
Contributor Author

Add * support for pattern matching
Requested by #106

Copy link
Owner

@muesli muesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Sorry for all the nitpicky typo comments 😃

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@muesli
Copy link
Owner

muesli commented Mar 28, 2021

I'm going to rebase master on top of your work, in the hope that it fixes the CI error.

@IGLOU-EU
Copy link
Contributor Author

Nice! Sorry for all the nitpicky typo comments 😃

Ho ... I'm so sorry about that 😖

@IGLOU-EU IGLOU-EU requested a review from muesli March 28, 2021 12:56
go.sum Outdated Show resolved Hide resolved
@IGLOU-EU
Copy link
Contributor Author

IGLOU-EU commented Apr 2, 2021

this is ok for you @muesli ?

@IGLOU-EU IGLOU-EU requested a review from muesli April 2, 2021 22:43
@muesli
Copy link
Owner

muesli commented Apr 3, 2021

Will give it one final review today!

@muesli
Copy link
Owner

muesli commented Apr 9, 2021

Ok, played with this and it's looking good. However on my first try I fell for a trap:

duf --only-mp /foobar/*

This of course uses the shell's globbing and delivers unexpected results. I'm thinking we'll need to provide some examples in the README and point out that caveat, to avoid confusion. I'll take care of this and push some updates to your branch, which should finally finish this up.

Thank you for your contribution and all the work involved!

go.mod Outdated Show resolved Hide resolved
@IGLOU-EU IGLOU-EU requested a review from muesli April 9, 2021 11:47
@IGLOU-EU
Copy link
Contributor Author

Thank you for your time and review. Many would like to get more involved in Free Software, and it's with people like you that we can :)

@muesli
Copy link
Owner

muesli commented Apr 14, 2021

Thank you for your time and review. Many would like to get more involved in Free Software, and it's with people like you that we can :)

I'm glad to hear you enjoy contributing to open-source! Looking forward to many more contributions!

Will give this a final review before this weekend and merge it!

Copy link
Owner

@muesli muesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
IGLOU-EU and others added 13 commits April 21, 2021 10:44
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
Signed-off-by: Adrien Kara <adrien@iglou.eu>
@muesli muesli added the enhancement New feature or request label Apr 21, 2021
@muesli muesli merged commit a200812 into muesli:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to hide a named mount point?
3 participants