Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-select scopes in new token link #12

Closed
FiXato opened this issue Sep 6, 2021 · 4 comments
Closed

Pre-select scopes in new token link #12

FiXato opened this issue Sep 6, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@FiXato
Copy link
Contributor

FiXato commented Sep 6, 2021

Might it be an idea to pre-select the required scopes in the "new personal access token" link in the README by adding the relevant scopes as comma-separated values for the 'scopes' parameter, e.g.: https://github.com/settings/tokens/new?scopes=repo:status,public_repo,read:user,read:org

@muesli
Copy link
Owner

muesli commented Sep 7, 2021

That's a fantastic idea! Mind opening a pull request with that change? ❤️

@muesli muesli added the documentation Improvements or additions to documentation label Sep 7, 2021
FiXato added a commit to FiXato/gitty that referenced this issue Sep 7, 2021
As per issue muesli#12 this change pre-fills the minimum required scopes for the personal access token.
I've also included a default description of 'gitty' for the 'note' field.
Since the link now points directly to the 'new token' form, I've also changed the clickable part of the sentence from 'profile settings' to 'create a new token' to better reflect the action of the link.
@FiXato
Copy link
Contributor Author

FiXato commented Sep 7, 2021

Done :)

@elbosso
Copy link

elbosso commented Sep 7, 2021

Just a thought - when gitty does not find either GITHUB_TOKEN or GITTY_TOKEN - would it be possible and considered practical to open the browser at that location (maybe after asking for permission to do so)?

029221e

muesli pushed a commit that referenced this issue Sep 7, 2021
As per issue #12 this change pre-fills the minimum required scopes for the personal access token.
I've also included a default description of 'gitty' for the 'note' field.
Since the link now points directly to the 'new token' form, I've also changed the clickable part of the sentence from 'profile settings' to 'create a new token' to better reflect the action of the link.
@muesli
Copy link
Owner

muesli commented Sep 7, 2021

@elbosso I agree, we should ideally do that. Mind opening a separate issue for that feature?

@muesli muesli closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants