Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30 extract the cdk test into its own lib #42

Merged
merged 4 commits into from
Aug 6, 2023

Conversation

muhamadto
Copy link
Owner

Hello, Please Review My Pull Request!

✔️ Checklist

  • Describe what you did in the pull request description
  • Add Unit and Integration Tests - at least 80% unit tests for new code.
  • Added or updated documentation

Extracted the CDK assertions logic to `https://github.com/muhamadto/cdk-fluent-assertions` and imported the resulting library `com.coffeebeans:cdk-fluent-assertions:1.0.0` to this project to be used in testing

Signed-off-by: muhamadto <muhamadto@gmail.com>
Extracted the CDK assertions logic to `https://github.com/muhamadto/cdk-fluent-assertions` and imported the resulting library `com.coffeebeans:cdk-fluent-assertions:1.0.0` to this project to be used in testing

Signed-off-by: muhamadto <muhamadto@gmail.com>
@muhamadto muhamadto linked an issue Jun 7, 2023 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@muhamadto muhamadto merged commit 03fa06b into main Aug 6, 2023
8 checks passed
@muhamadto muhamadto deleted the 30-extract-the-cdk-test-into-its-own-lib branch August 6, 2023 08:48
muhamadto added a commit that referenced this pull request Aug 6, 2023
* 30 extract the cdk test into its own lib (#42)

Imported `com.coffeebeans:cdk-fluent-assertions`

Extracted the CDK assertions logic to `https://github.com/muhamadto/cdk-fluent-assertions` and imported the resulting library `com.coffeebeans:cdk-fluent-assertions:1.0.0` to this project to be used in testing

Signed-off-by: muhamadto <muhamadto@gmail.com>

* Bump guava from 31.1-jre to 32.0.0-jre (#46)

Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump guava from 31.1-jre to 32.0.0-jre (#43)

Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: muhamadto <muhamadto@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the CDK test into its own lib
1 participant