Adapt CLI with changes in TailwindCSS V3 #281
Conversation
muhammadsammy
changed the title
| cls => '!' + cls, | ||
| ); | ||
| // Duplicate classnames with an important (!) prefix | ||
| const generatedClassGroupWithImportantPrefix = generatedClassGroup.map(cls => '!' + cls); |
There was a problem hiding this comment.
Not sure if it would improve or worsen perf, but some of the things this lib is doing can be accomplished using template string types:
export type TClassesWithModifiers = `!${TClasses}` | TClassesThis could potentially be used to implement a lot of things in the lib with less code.
There was a problem hiding this comment.
Thank you! I think this will make file size much smaller
Would you like to make a PR with this change to be merged into master for v2 releases?
There was a problem hiding this comment.
I'm already using Tailwind 3 myself, so I thought maybe I should do the changes on top of this PR. Do you think that would be a good idea?
There was a problem hiding this comment.
Hey, I've tested this approach on pseudoclasses, and it was extremely slow
But it was OK when applying this approach to important modifiers only
There was a problem hiding this comment.
And yes, it makes more sense to do the changes on top of this PR. Thank you!
The issue still remains with classes with colors
was generating: `border--red-100`
This PR contains the following:
Tailwind V3 changes:
vertical-alignvalues to config file instead of hard-coding (#5487)overflow-cliptotext-clipandoverflow-ellipsistotext-ellipsis(#5630)tailwindcss-classnames:
fontFamily("font-sans", "sm:font-mono"),display("flex"))