Support custom values for vertical-align utilities
#5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
changed the title
vertical-align utilitiesvertical-align utilities
23 tasks
8 tasks
45 tasks
|
@adamwathan It seems to me like you forgot to add the theme property from which to get the values for vertical-align here. Shouldn't it be defined here? https://github.com/tailwindlabs/tailwindcss/pull/5487/files#diff-cf9185e083748e39c6940d3ad337df23b0ecbbd70b9550f596de7cf4b4668bcfR1498 I also tried it out in the Tailwind playground but only arbitrary values work for vertical-align at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
vertical-alignutilities configurable via thetailwind.config.jsfile so that users can add custom values (sincevertical-alignsupports values like10px,15%, etc.), which also makes it possible to use arbitrary values likealign-[5em].This is technically a very small breaking change, as anyone using
preset: []in their config file to disable the default Tailwind config will no longer have anyvertical-alignutilities generated. I considered doing something unusual here to make it non-breaking but it would have introduced weird inconsistency into the framework that I think would have been more harmful than helpful. I expect this will affect very, very few users.