Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Prepare the async API #10523

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

@mbrookes
Copy link
Member

mbrookes commented Mar 4, 2018

Any chance of a couple of code comments so future maintainers know what's going on here?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 4, 2018

@mbrookes It's far from being completed. It's 0.5% of the work needed. I think that the pull-request will grow to +1000 -1000 if not more. So yes, React changes will lead to profound changes here 🚧.

@nicholas-l
Copy link
Contributor

Why not use react-lifecycles-compat instead of creating componentNew?

@oliviertassinari
Copy link
Member Author

@nicholas-l I didn't know the project! Thanks for sharing.

@oliviertassinari oliviertassinari force-pushed the prepare-react-16-3 branch 3 times, most recently from 3e2b6d8 to e9146d3 Compare March 4, 2018 21:18
@oliviertassinari oliviertassinari merged commit 855367e into mui:v1-beta Mar 4, 2018
@oliviertassinari oliviertassinari deleted the prepare-react-16-3 branch March 4, 2018 21:40
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 4, 2018

This pull-request is half of the job done. We still have to migrate:

  • componentWillUpdate x1
  • componentWillReceiveProps x10

Let's ship this change to our users, and commit more effort if everything goes smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants