Bump jsdom from 16.3.0 to 16.4.0 #22124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
|
No bundle size changes comparing 1982dc2...79ff5a7 |
|
Resolve jsdom/jsdom#3025 first. |
github-actions
bot
added
the
PR: out-of-date
Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.3.0 to 16.4.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md) - [Commits](jsdom/jsdom@16.3.0...16.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
eps1lon
reviewed
Aug 10, 2020
| @@ -1,5 +1,5 @@ | |||
| module.exports = { | |||
| recursive: true, | |||
| reporter: 'dot', | |||
| require: [require.resolve('@babel/register'), require.resolve('./test/utils/setup')], | |||
| require: [require.resolve('@babel/register'), require.resolve('./test/utils/setupJSDOM')], | |||
There was a problem hiding this comment.
It's really about setting up JSDOM. I was always confused by the two init and setup files which are essentially synonyms in this context.
eps1lon
reviewed
Aug 10, 2020
| function isInJSDOM() { | ||
| return /jsdom/.test(window.navigator.userAgent); | ||
| } | ||
|
|
||
| function isInKarma() { |
There was a problem hiding this comment.
The usage is specific to karma. Having a isInBrowser = !isInJSDOM would not be accurate.
eps1lon
force-pushed
the
dependabot/npm_and_yarn/jsdom-16.4.0
branch
from
131e925
to
863683d
Compare
github-actions
bot
removed
the
PR: out-of-date
|
Also shaving off 10s (50s down from 60s) in |
oliviertassinari
approved these changes
Aug 12, 2020
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/jsdom-16.4.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps jsdom from 16.3.0 to 16.4.0.
Changelog
Sourced from jsdom's changelog.
Commits
5279cfdVersion 16.4.03802e13Fix several bugs in <img>.completebfa4902When removing the focused element, focus the body20b3971Add basic processing for second getComputedStyle() argument4a49111Fix case insensitivity for translate="" and draggable=""63d24a0Cache Element's tagNamec2fb8ffFix the valueMissing check for <input type=radio>574eb51Implement focusability for SVG elements252b828Do not allow focusing disconnected nodesaf7e1d9Fix form.elements to use form owner instead of only descendantsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: