Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Checkbox and Number Field images #292

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

danilo-leal
Copy link
Contributor

Follow up to #288 (comment). Still iterating on the dark mode styles for these images. Not sure I'm fully happy with it yet 😬

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Apr 11, 2024
@danilo-leal danilo-leal self-assigned this Apr 11, 2024
@colmtuite
Copy link
Contributor

Approved ✅ It's fine for now, but these should be done with CSS rather than <img /> for a few benefits:

  1. We don't need to maintain an external file in Figma.
  2. Improved perf since we don't need to download ~50 images.
  3. We get dark mode for free. No need to draw, maintain, load separate images.
  4. We can do micro animations if we want.

@danilo-leal danilo-leal merged commit fcb2a57 into mui:master Apr 11, 2024
14 checks passed
@danilo-leal danilo-leal deleted the add-new-all-components-images branch April 11, 2024 09:55
@danilo-leal
Copy link
Contributor Author

danilo-leal commented Apr 11, 2024

michaldudak pushed a commit to michaldudak/base-ui that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants