[eslint] enforce import plugin rules (#6923)

* [eslint] use webpackBaseConfig.js for resolution instead of dev.
* [eslint] docs webpack configs must ignore non-existent build artifact

.eslintrc.js

@@ -27,7 +27,7 @@ module.exports = {
   settings: {
     'import/resolver': {
       webpack: {
-        config: 'webpack.config.js',
+        config: './docs/webpackBaseConfig.js',
       },
     },
   },
@@ -49,12 +49,9 @@ module.exports = {
 
     'babel/object-curly-spacing': ['error', 'always'],
 
-    'import/unambiguous': 'off',
-    'import/no-unresolved': 'off',
-    'import/no-named-as-default': 'off',
-    'import/extensions': 'off',
+    'import/unambiguous': 'off',  // scripts
+    'import/namespace': ['error', { allowComputed: true }],
     'import/no-extraneous-dependencies': 'off',
-    'import/prefer-default-export': 'off',
 
     'react/jsx-handler-names': ['error', { // airbnb is disabling this rule
       eventHandlerPrefix: 'handle',

docs/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  settings: {
+    'import/resolver': {
+      webpack: {
+        config: './webpackBaseConfig.js',
+      },
+    },
+  },
+};

docs/src/index.js

@@ -1,4 +1,5 @@
 // @flow
+/* eslint-disable import/prefer-default-export */
 
 import { AppContainer } from 'react-hot-loader';
 import { createStore } from 'redux';

docs/webpack.dev.config.js

@@ -1,4 +1,5 @@
 // @flow weak
+/* eslint-disable import/no-unresolved */
 
 const webpack = require('webpack');
 const webpackBaseConfig = require('./webpackBaseConfig');

docs/webpack.prod.config.js

@@ -1,4 +1,6 @@
 // @flow weak
+/* eslint-disable import/no-unresolved */
+
 const webpack = require('webpack');
 const webpackBaseConfig = require('./webpackBaseConfig');
 const dllManifest = require('./build/dll.manifest.json');

package.json

@@ -95,6 +95,7 @@
     "enzyme": "^2.8.2",
     "eslint": "^3.19.0",
     "eslint-config-airbnb": "^15.0.0",
+    "eslint-import-resolver-webpack": "^0.8.1",
     "eslint-plugin-babel": "^4.1.1",
     "eslint-plugin-flowtype": "^2.33.0",
     "eslint-plugin-import": "^2.2.0",

packages/material-ui-icons/.eslintrc.js

@@ -0,0 +1,14 @@
+module.exports = {
+  settings: {
+    'import/resolver': {
+      webpack: {
+        config: '../../docs/webpackBaseConfig.js',
+      },
+    },
+  },
+  rules: {
+    // needed for mustache and temp
+    'import/no-unresolved': 'off',
+    'import/extensions': 'off',
+  }
+};

src/AppBar/AppBar.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import AppBar, { styleSheet } from './AppBar';
 
 describe('<AppBar />', () => {

src/Avatar/Avatar.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Avatar, { styleSheet } from './Avatar';
 import CancelIcon from '../svg-icons/cancel';
 

src/Badge/Badge.spec.js

@@ -1,8 +1,8 @@
 // @flow
 
 import React from 'react';
-import { createShallow } from 'src/test-utils';
 import { assert } from 'chai';
+import { createShallow } from '../test-utils';
 import Badge, { styleSheet } from './Badge';
 
 describe('<Badge />', () => {

src/BottomNavigation/BottomNavigation.spec.js

@@ -3,7 +3,7 @@
 import React from 'react';
 import { assert } from 'chai';
 import { spy } from 'sinon';
-import { createShallow, createMount } from 'src/test-utils';
+import { createShallow, createMount } from '../test-utils';
 import BottomNavigation, { styleSheet } from './BottomNavigation';
 import BottomNavigationButton from './BottomNavigationButton';
 import Icon from '../Icon';

src/BottomNavigation/BottomNavigationButton.spec.js

@@ -3,7 +3,7 @@
 import React from 'react';
 import { assert } from 'chai';
 import { spy } from 'sinon';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import BottomNavigationButton, { styleSheet } from './BottomNavigationButton';
 import Icon from '../Icon';
 

src/Button/Button.spec.js

@@ -3,7 +3,7 @@
 import React from 'react';
 import { assert } from 'chai';
 import htmlLooksLike from 'html-looks-like';
-import { createShallow, createRenderToString } from 'src/test-utils';
+import { createShallow, createRenderToString } from '../test-utils';
 import Button, { styleSheet } from './Button';
 
 describe('<Button />', () => {

src/Card/Card.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Card, { styleSheet } from './Card';
 
 describe('<Card />', () => {

src/Card/CardActions.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import CardActions, { styleSheet } from './CardActions';
 
 describe('<CardActions />', () => {

src/Card/CardContent.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import CardContent, { styleSheet } from './CardContent';
 
 describe('<CardContent />', () => {

src/Card/CardHeader.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import CardHeader, { styleSheet } from './CardHeader';
 
 describe('<CardHeader />', () => {

src/Card/CardMedia.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import CardMedia, { styleSheet } from './CardMedia';
 
 describe('<CardMedia />', () => {

src/Checkbox/Checkbox.spec.js

@@ -1,7 +1,7 @@
 // @flow
 
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Checkbox, { LabelCheckbox, styleSheet } from './Checkbox';
 
 describe('<Checkbox />', () => {

src/Chip/Chip.spec.js

@@ -4,7 +4,7 @@ import React from 'react';
 import keycode from 'keycode';
 import { assert } from 'chai';
 import { spy } from 'sinon';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Chip, { styleSheet } from './Chip';
 import Avatar from '../Avatar';
 

src/Dialog/Dialog.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Dialog, { styleSheet } from './Dialog';
 import Paper from '../Paper';
 

src/Dialog/DialogActions.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import DialogActions, { styleSheet } from './DialogActions';
 
 describe('<DialogActions />', () => {

src/Dialog/DialogContent.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import DialogContent, { styleSheet } from './DialogContent';
 
 describe('<DialogContent />', () => {

src/Dialog/DialogContentText.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import DialogContentText, { styleSheet } from './DialogContentText';
 
 describe('<DialogContentText />', () => {

src/Dialog/DialogTitle.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import DialogTitle, { styleSheet } from './DialogTitle';
 
 describe('<DialogTitle />', () => {

src/Dialog/withResponsiveFullScreen.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Paper from '../Paper';
 import Dialog, { styleSheet } from './Dialog';
 import withResponsiveFullScreen from './withResponsiveFullScreen';

src/Divider/Divider.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Divider, { styleSheet } from './Divider';
 
 describe('<Divider />', () => {

src/Drawer/Drawer.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Drawer, { styleSheet } from './Drawer';
 import Slide from '../transitions/Slide';
 import Modal from '../internal/Modal';

src/Form/FormControl.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import FormControl, { styleSheet } from './FormControl';
 
 describe('<FormControl />', () => {

src/Form/FormGroup.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import FormGroup, { styleSheet } from './FormGroup';
 
 describe('<FormGroup />', () => {

src/Form/FormLabel.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import FormLabel, { styleSheet } from './FormLabel';
 
 describe('<FormLabel />', () => {

src/Grid/Grid.spec.js

@@ -2,8 +2,8 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
 import forOwn from 'lodash/forOwn';
+import { createShallow } from '../test-utils';
 import Grid, { styleSheet } from './Grid';
 import Hidden from '../Hidden';
 

src/Hidden/Hidden.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Hidden from './Hidden';
 import HiddenJs from './HiddenJs';
 

src/Hidden/HiddenJs.spec.js

@@ -3,7 +3,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import HiddenJs from './HiddenJs';
 import type { Breakpoint } from '../styles/breakpoints';
 import Typography from '../Typography';

src/Icon/Icon.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import Icon, { styleSheet } from './Icon';
 
 describe('<Icon />', () => {

src/IconButton/IconButton.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import IconButton, { styleSheet } from './IconButton';
 import Icon from '../Icon';
 

src/Input/Input.spec.js

@@ -3,7 +3,7 @@
 import React from 'react';
 import { assert } from 'chai';
 import { spy } from 'sinon';
-import { createShallow, createMount } from 'src/test-utils';
+import { createShallow, createMount } from '../test-utils';
 import Textarea from './Textarea';
 import Input, { styleSheet } from './Input';
 

src/Input/InputLabel.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import InputLabel, { styleSheet } from './InputLabel';
 
 describe('<InputLabel />', () => {

src/Input/Textarea.spec.js

@@ -3,7 +3,7 @@
 import React from 'react';
 import { assert } from 'chai';
 import { spy } from 'sinon';
-import { createShallow, createMount } from 'src/test-utils';
+import { createShallow, createMount } from '../test-utils';
 import Textarea from './Textarea';
 
 describe('<Textarea />', () => {

src/List/List.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import List, { styleSheet } from './List';
 import ListSubheader from './ListSubheader';
 

src/List/ListItem.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import ListItem, { styleSheet } from './ListItem';
 
 /**

src/List/ListItemAvatar.spec.js

@@ -2,7 +2,7 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow } from 'src/test-utils';
+import { createShallow } from '../test-utils';
 import ListItemAvatar, { styleSheet } from './ListItemAvatar';
 import Avatar from '../Avatar';