Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] enforce import plugin rules #6923

Merged
merged 4 commits into from May 23, 2017

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented May 22, 2017

Most of the eslint-import-plugin rules were disabled. I added the webpack resolver, pointing it at the docs/webpack.dev.config.js as it had the aliases setup that check most of the code.

I removed disabled rules and configured a few local exceptions using subordinate eslintrc.js files.

Since we make one eslint run, we have to disable import resolution checks in some cases because we are using multiple package.json files, and it is one execution to one package.json. I focused on hardening the src imports and secondarily docs.

Aside from setup, I fixed a few import related consistency issues that it exposed.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@rosskevin rosskevin added the next label May 22, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels May 22, 2017
@rosskevin
Copy link
Member Author

I'm working on the error, it only fails on circleci and I can't quite track it down so I'm ssh'd into the build trying to track it down. If anyone knows how the ci build error is related, please let me know.

The dev webpack config was importing the build artifact which caused failures.
@rosskevin
Copy link
Member Author

Found it.

@rosskevin rosskevin merged commit 0e6f8d9 into mui:next May 23, 2017
@rosskevin rosskevin deleted the eslint-import-settings branch May 23, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants