[eslint] enforce import plugin rules #6923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the eslint-import-plugin rules were disabled. I added the webpack resolver, pointing it at the docs/webpack.dev.config.js as it had the aliases setup that check most of the code.
I removed disabled rules and configured a few local exceptions using subordinate eslintrc.js files.
Since we make one eslint run, we have to disable import resolution checks in some cases because we are using multiple package.json files, and it is one execution to one package.json. I focused on hardening the src imports and secondarily docs.
Aside from setup, I fixed a few import related consistency issues that it exposed.