[docs] Fix missing href for AppDrawerNavItems (#27936)

mui · Aug 24, 2021 · 6ea1867 · 6ea1867
1 parent 6207e10
commit 6ea1867
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 14 deletions.
diff --git a/docs/src/components/productDesignKit/DesignKitDemo.tsx b/docs/src/components/productDesignKit/DesignKitDemo.tsx
@@ -65,7 +65,7 @@ export default function TemplateDemo() {
                 />
               </Highlighter>
             ))}
-            <More component={Link} href={ROUTES.storeDesign} passHref noLinkStyle />
+            <More component={Link} href={ROUTES.storeDesign} noLinkStyle />
           </Group>
         </Grid>
         <Grid item xs={12} md={6}>
@@ -177,7 +177,6 @@ export default function TemplateDemo() {
               </Box>
               <Button
                 component={Link}
-                passHref
                 noLinkStyle
                 href={ROUTES.storeDesign}
                 endIcon={<LaunchRounded sx={{ '&&': { fontSize: 16 } }} />}

diff --git a/docs/src/components/productDesignKit/DesignKitFAQ.tsx b/docs/src/components/productDesignKit/DesignKitFAQ.tsx
@@ -29,11 +29,9 @@ const faqData = [
     detail: (
       <React.Fragment>
         We&apos;ll send you an email when a new release is available. You can access the item on the{' '}
-        <InternalLink href="/store/account/download" passHref>
-          download
-        </InternalLink>{' '}
-        page of your store account. You can find a detailed description of the changes under the
-        &quot;Changelog&quot; tab on this page.
+        <InternalLink href="/store/account/download">download</InternalLink> page of your store
+        account. You can find a detailed description of the changes under the &quot;Changelog&quot;
+        tab on this page.
       </React.Fragment>
     ),
   },

diff --git a/docs/src/components/productDesignKit/DesignKitHero.tsx b/docs/src/components/productDesignKit/DesignKitHero.tsx
@@ -43,7 +43,6 @@ export default function TemplateHero() {
           </Typography>
           <Button
             component={Link}
-            passHref
             noLinkStyle
             href={ROUTES.storeDesign}
             size="large"

diff --git a/docs/src/components/productTemplate/TemplateHero.tsx b/docs/src/components/productTemplate/TemplateHero.tsx
@@ -42,7 +42,6 @@ export default function TemplateHero() {
           </Typography>
           <Button
             component={Link}
-            passHref
             noLinkStyle
             href={ROUTES.storePopular}
             size="large"

diff --git a/docs/src/modules/components/Link.tsx b/docs/src/modules/components/Link.tsx
@@ -8,18 +8,17 @@ import { useUserLanguage } from 'docs/src/modules/utils/i18n';
 
 interface NextLinkComposedProps
   extends Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, 'href'>,
-    Omit<NextLinkProps, 'href' | 'as'> {
+    Omit<NextLinkProps, 'href' | 'as' | 'passHref'> {
   to: NextLinkProps['href'];
   linkAs?: NextLinkProps['as'];
   href?: NextLinkProps['href'];
 }
 
 const Anchor = styled('a')({ cursor: 'pointer' });
 
-export const NextLinkComposed = React.forwardRef<HTMLAnchorElement, NextLinkComposedProps>(
+const NextLinkComposed = React.forwardRef<HTMLAnchorElement, NextLinkComposedProps>(
   function NextLinkComposed(props, ref) {
-    const { to, linkAs, href, replace, scroll, passHref, shallow, prefetch, locale, ...other } =
-      props;
+    const { to, linkAs, href, replace, scroll, shallow, prefetch, locale, ...other } = props;
 
     return (
       <NextLink
@@ -29,7 +28,7 @@ export const NextLinkComposed = React.forwardRef<HTMLAnchorElement, NextLinkComp
         replace={replace}
         scroll={scroll}
         shallow={shallow}
-        passHref={passHref}
+        passHref
         locale={locale}
       >
         <Anchor ref={ref} {...other} />