New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix missing href
for AppDrawerNavItems
#27936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Aug 24, 2021
to: NextLinkProps['href']; | ||
linkAs?: NextLinkProps['as']; | ||
href?: NextLinkProps['href']; | ||
} | ||
|
||
const Anchor = styled('a')({ cursor: 'pointer' }); | ||
|
||
export const NextLinkComposed = React.forwardRef<HTMLAnchorElement, NextLinkComposedProps>( | ||
const NextLinkComposed = React.forwardRef<HTMLAnchorElement, NextLinkComposedProps>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never used so don't export it.
1 task
eps1lon
added
bug 🐛
Something doesn't work
docs
Improvements or additions to the documentation
labels
Aug 24, 2021
50 tasks
siriwatknp
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thoughts:
|
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
Sep 5, 2021
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
Sep 5, 2021
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nav items didn't include the common affordances for links (e.g. open new tab, copy link adress etc).
Before: https://6124b8cbdf676e0008cc3e43--material-ui.netlify.app/components/box/
After: https://deploy-preview-27936--material-ui.netlify.app/components/box/
Bisecting lead to 49f21f8 which makes sense since the child element of
next/link
no longer had thea
type and therefore needed an explicitpassHref
.It's unclear why
passHref
was a supported prop. It wouldn't be useful since the child type is controlled by the implementation not its usage. But we may have destructured it inNextLinkComposed
because its callsites didn't properly filterpassHref
. This is a responsibility of the callsite ofNextLinkComposed
. Good thing is thatpassHref
leaking to ana
would trigger React warnings so we'll see if this is/was ever an issue.