Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon-builder: fileSuffix / non-mui icons broken #1139

Closed
tony opened this issue Jul 12, 2015 · 1 comment
Closed

icon-builder: fileSuffix / non-mui icons broken #1139

tony opened this issue Jul 12, 2015 · 1 comment
Labels
package: icons Specific to @mui/icons

Comments

@tony
Copy link
Contributor

tony commented Jul 12, 2015

Related: #1130 The approach we're taking now with fileSuffix in 0.10 won't work with arbitrary svg icons packages.

  1. fileSuffix chops of 3 characters from beginning of files, does a find/replace only necessary for mui icons
  2. The fixture for game-icons shows when dealing with arbitrary SVG icon packages, there can be a lot of redundant nesting. https://github.com/tony/material-ui/blob/cff463fe482ce923de41c55e2d7b7cefe6d0d6f4/icon-builder/test/fixtures/game-icons/icons/delapouite/dice/svg/000000/transparent/dice-six-faces-four.svg

In the short term, let's fix what we already have. Looking forward, we can investigate something like gulp for processing.
tony added a commit to tony/material-ui that referenced this issue Jul 12, 2015
@tony
mui#1139 split file renaming into module / argument.
034c96a
tony added a commit to tony/material-ui that referenced this issue Jul 13, 2015
@tony
For mui#1127:
ec948e3 
- Add grunt, mocha.
- Modularize functions in build.
- Tests for functions and types.
- Grunt watch for rerunning tests on file save.
- Wrap argv in main() + only run when executing as a script.
- main() now accepts parameterized object literal for simulating args.
- mui#1139 split file renaming into module / argument.
tony added a commit to tony/material-ui that referenced this issue Jul 13, 2015
@tony
icon-builder tests, grunt, fix mui#1127 mui#1126 mui#1125 mui#1139
1dd6409 
- Add grunt, mocha.
- Modularize functions in build.
- Tests for functions and types.
- Grunt watch for rerunning tests on file save.
- Wrap argv in main() + only run when executing as a script.
- main() now accepts parameterized object literal for simulating args.
- mui#1139 split file renaming into module / argument.
tony added a commit to tony/material-ui that referenced this issue Jul 13, 2015
@tony
icon-builder tests, grunt, fix mui#1127 mui#1126 mui#1125 mui#1139
a8ac948 
- Add grunt, mocha.
- Modularize functions in build.
- Tests for functions and types.
- Grunt watch for rerunning tests on file save.
- Wrap argv in main() + only run when executing as a script.
- main() now accepts parameterized object literal for simulating args.
- mui#1139 split file renaming into module / argument.
tony added a commit to tony/material-ui that referenced this issue Jul 14, 2015
@tony
icon-builder tests, grunt, fix mui#1127 mui#1126 mui#1125 mui#1139
005d517 
- Add grunt, mocha.
- Modularize functions in build.
- Tests for functions and types.
- Grunt watch for rerunning tests on file save.
- Wrap argv in main() + only run when executing as a script.
- main() now accepts parameterized object literal for simulating args.
- mui#1139 split file renaming into module / argument.
- Tests + Fixture for result output.
tony added a commit to tony/material-ui that referenced this issue Jul 14, 2015
@tony
icon-builder tests, grunt, fix mui#1127 mui#1126 mui#1125 mui#1139
9782c5a 
- Add grunt, mocha.
- Modularize functions in build.
- Tests for functions and types.
- Grunt watch for rerunning tests on file save.
- Wrap argv in main() + only run when executing as a script.
- main() now accepts parameterized object literal for simulating args.
- mui#1139 split file renaming into module / argument.
- Tests + Fixture for result output.
hai-cea added a commit that referenced this issue Jul 16, 2015
@hai-cea
Merge pull request #1130 from tony/icon-builder-test
0004660 
#1127 #1126 #1125 #1139 Icon builder tests, grunt, templating
@hai-cea
Copy link
Member

hai-cea commented Jul 31, 2015

Fixed with #1130 - Thanks @tony

@hai-cea hai-cea closed this as completed Jul 31, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dmtrKovalenko
[mui#1126] Fix rerendering loop (mui#1139)
0567091
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added package: icons Specific to @mui/icons and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tony @hai-cea @oliviertassinari @zannager