[Autocomplete] An error occurs when changing multiple

[weizhi9958]

• I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior

An error occurs when changing multiple
A component is changing the default value state of an uncontrolled Autocomplete after being initialized. To suppress this warning opt to use a controlled Autocomplete.

Expected Behavior

No error

Steps to Reproduce

https://codesandbox.io/s/solitary-http-e0zzh?file=/App.js

[weizhi9958]

What can i do?
Would you give me more information?

[oliviertassinari]

@weizhi9958 You are right, the warning shouldn't be thrown in this context. Thanks for the report. What do you think of this patch?

diff --git a/packages/material-ui/src/utils/useControlled.js b/packages/material-ui/src/utils/useControlled.js
index dab0f9039..730ccb30a 100644
--- a/packages/material-ui/src/utils/useControlled.js
+++ b/packages/material-ui/src/utils/useControlled.js
@@ -27,7 +27,7 @@ export default function useControlled({ controlled, default: defaultProp, name,
     const { current: defaultValue } = React.useRef(defaultProp);

     React.useEffect(() => {
-      if (defaultValue !== defaultProp) {
+      if (!isControlled && defaultValue !== defaultProp) {
         console.error(
           [
             `Material-UI: A component is changing the default ${state} state of an uncontrolled ${name} after being initialized. ` +
@@ -35,7 +35,7 @@ export default function useControlled({ controlled, default: defaultProp, name,
           ].join('\n'),
         );
       }
    }, [JSON.stringify(defaultProp)]);
   }

   const setValueIfUncontrolled = React.useCallback((newValue) => {

Do you want to submit a pull request? :)

[marcosvega91]

maybe could be better to check JSON.stringify of both attribute.
if (!isControlled && JSON.stringify(defaultValue) !== JSON.stringify(defaultProp)) {

[oliviertassinari]

@marcosvega91 I don't know. I believe we use JSON.stringify here to support people that provide rich default objects. What would this change help to achieve?

[marcosvega91]

Thinking better you are right. Never mind 😃