New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix dynamic changes of multiple={boolean} #21194
Merged
oliviertassinari
merged 4 commits into
mui:master
from
weizhi9958:fix-autocomplete-uncontrolled
May 26, 2020
Merged
[Autocomplete] Fix dynamic changes of multiple={boolean} #21194
oliviertassinari
merged 4 commits into
mui:master
from
weizhi9958:fix-autocomplete-uncontrolled
May 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 3443d2c...e0ac0ab Details of page changes
|
eps1lon
added
component: autocomplete
This is the name of the generic UI component, not the React module!
PR: needs test
The pull request can't be merged
labels
May 25, 2020
eps1lon
reviewed
May 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test that was failing prior to this change?
eps1lon
reviewed
May 25, 2020
NMinhNguyen
reviewed
May 25, 2020
oliviertassinari
changed the title
[Autocomplete] fix useControlled issue
[Autocomplete] Support dynamic changes of multiple={boolean}
May 25, 2020
oliviertassinari
changed the title
[Autocomplete] Support dynamic changes of multiple={boolean}
[Autocomplete] Fix dynamic changes of multiple={boolean}
May 25, 2020
oliviertassinari
added
bug 🐛
Something doesn't work
and removed
PR: needs test
The pull request can't be merged
labels
May 25, 2020
oliviertassinari
approved these changes
May 25, 2020
@weizhi9958 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
Thanks everyone for your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21136