Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] can't tap on text input to change cursor location #6888

Closed
jony89 opened this issue May 17, 2017 · 1 comment
Closed

[Popover] can't tap on text input to change cursor location #6888

jony89 opened this issue May 17, 2017 · 1 comment
Labels
bug 🐛 Something doesn't work component: Popover The React component.

Comments

@jony89
Copy link
Contributor

jony89 commented May 17, 2017

Problem description

When I'm trying to click (actually tap) within the text input in order to change the cursor location, nothing happens.

This is fixed when I am removing the following line:

event.preventDefault();

from componentClickAway function in the Popover component.

otherwise I also get the following warning:

index.js:8931 Ignored attempt to cancel a touchstart event with cancelable=false, for example because scrolling is in progress and cannot be interrupted

pointing to that code.

I'm not sure what are the implication of removing that line ?

Link to minimal working code that reproduces the issue

Just take any autocomplete example and run it on simulator without the inspector being on! (without debugging), write some text and try by tapping (or clicking) changing the cursor location within the input text box.

Versions

  • Material-UI: 0.18.1
  • React: 0.15.4
  • Browser: only on android emulator / device or iphone emulator / device
    didn't check windows phone
@jony89 jony89 changed the title [Popover]+[Autocomplete] cant tap on text input to change cursor location [Popover]+[Autocomplete] can't tap on text input to change cursor location May 17, 2017
@jony89
Copy link
Contributor Author

jony89 commented May 17, 2017

I'm pretty sure that if useLayerForClickAway is false then :

    event.preventDefault();
    this.requestClose('clickAway');

should not occur within componentClickAway func

@oliviertassinari oliviertassinari added component: Popover The React component. PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI bug 🐛 Something doesn't work and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels May 17, 2017
@oliviertassinari oliviertassinari changed the title [Popover]+[Autocomplete] can't tap on text input to change cursor location [Popover] can't tap on text input to change cursor location May 17, 2017
oliviertassinari added a commit that referenced this issue Jun 17, 2017
Closes #6888

should not call clickAway if useLayerForClickAway is false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Popover The React component.
Projects
None yet
Development

No branches or pull requests

2 participants