[Popover] Only prevent default click interactions #7167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Closes #6888 should not call clickAway if useLayerForClickAway is false
|
@jony89 Thanks for your help here! |
|
@oliviertassinari you are most welcome. just to mention, the event it is being triggered twice, not sure what are the implication. one time with |
|
@jony89 Yeah, but it's not triggered on desktop otherwise. I would rather make Material-UI less opinionated at that level. |
|
Thank you for fixing it! This also fixed a similar issue for me where a checkbox couldn't be unchecked. @jony89 @oliviertassinari when will |
|
it is done with SEMVER and every two weeks if I am correct. though you can always build the lib your self (npm run build after npm install) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert 8dac626 as I don't think that it's relevant to prevent default here. I would rather see it on specific elements.
Closes #6888
Closes #6891