-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INPUT and SELECT components do not respect GRID item space assignation #8544
Comments
The current behavior is the expected behavior. You need to use the <Grid container>
<Grid item xs={10}>
<div style={{ background: 'pink' }}>
<FormControl fullWidth>
<InputLabel style={{ background: 'yellow' }} htmlFor={factor.field_id}>{factor.editLabel}</InputLabel>
<Input style={{ background: 'cyan' }} id={factor.field_id} type="number" value="3" />
</FormControl>
</div>
</Grid>
</Grid> |
Excellent. The documentation for option fullWith says "If true, the label will take up the full width of its container.". Perhaps it should say something like "If true, the label and the input/select element will take up the full width of its container." or similar. I will use that. Thx |
@pabloa I like the suggestion. Do you want to update our documentation? |
No :)
But I will do it. Let me find out how to do it and I will.
P
…On Thu, Oct 5, 2017 at 12:00 PM, Olivier Tassinari ***@***.*** > wrote:
@pabloa <https://github.com/pabloa> I like the suggestion. Do you want to
update our documentation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8544 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAk_CzmiLEW5CKYFT1S-Sf2B25MV49lwks5spSdUgaJpZM4PuWWC>
.
|
Expected Behavior
When a INPUT or SELECT components are inside of GRID component, they should follow the layout established by the GRID component.
Current Behavior
Right now <INPUT and <SELECT are rendered without fill the space assigned by the GRID and they must be CSS styleshed 1 by 1. This is worst when the <INPUT has autocomplete because lot of CSS must be used for something that is expected: any component/html inside of a GRID item should use all the space assigned to it.
Steps to Reproduce (for bugs)
https://24zr5plwwy.codesandbox.io/
Context
I believe this is a problem because <INPUT and <SELECT are not following the space assignation rules of the <GRID component, making the <GRID component not so useful to build forms.
Your Environment
The text was updated successfully, but these errors were encountered: