Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox, Radio, Switch] Fix id in internal input #10196

Merged
merged 5 commits into from Feb 10, 2018
Merged

[Checkbox, Radio, Switch] Fix id in internal input #10196

merged 5 commits into from Feb 10, 2018

Conversation

phsantiago
Copy link
Contributor

@phsantiago phsantiago commented Feb 6, 2018 •
edited by oliviertassinari

This make the id of input wrapper goes down to input when it's a checkbox/radio/switch.

Closes #10113

Breaking change

For consistency between the Input and the Checkbox, Switch, Radio the following small breaking changes have been done:

  • The usage of the inputProps property is no longer needed to apply an id to the input. The id is applied to the input instead of the root.
-<Checkbox inputProps={{ id: 'id' }} />
+<Checkbox id="id" />
  • The inputType property was renamed type.
-<Checkbox inputType="text" />
+<Checkbox type="text" />

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Feb 6, 2018
@oliviertassinari oliviertassinari self-assigned this Feb 6, 2018
@oliviertassinari oliviertassinari added PR: accepted component: checkbox This is the name of the generic UI component, not the React module! component: switch This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! labels Feb 6, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 6, 2018 •
edited

We are pausing breaking changes for 1.0.0-beta.33. It will land in 1.0.0-beta.34.

@mbrookes mbrookes added the on hold There is a blocker, we need to wait label Feb 6, 2018
@mbrookes
Copy link
Member

mbrookes commented Feb 6, 2018

Record for most labels on a single PR?

@oliviertassinari oliviertassinari removed PR: accepted on hold There is a blocker, we need to wait labels Feb 10, 2018
@oliviertassinari oliviertassinari merged commit 43e03d6 into mui:v1-beta Feb 10, 2018
@phsantiago phsantiago deleted the fix/label-for branch February 11, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliviertassinari oliviertassinari

Labels
breaking change bug 🐛 Something doesn't work component: checkbox This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! component: switch This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phsantiago @oliviertassinari @mbrookes