Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox, Radio, Switch] Fix id in internal input #10196

Merged
merged 5 commits into from
Feb 10, 2018
Merged

[Checkbox, Radio, Switch] Fix id in internal input #10196

merged 5 commits into from
Feb 10, 2018

Commits on Feb 6, 2018

  1. added id on internal input when its a radio or checkbox

    @phsantiago @oliviertassinari
    phsantiago authored and oliviertassinari committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    0123578 View commit details
    Browse the repository at this point in the history

  2. tests to prevent regression

    @phsantiago @oliviertassinari
    phsantiago authored and oliviertassinari committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    072f05a View commit details
    Browse the repository at this point in the history

  3. add id on wrapper when input isn't a checkbox/radio/switch

    @phsantiago @oliviertassinari
    phsantiago authored and oliviertassinari committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    c66d953 View commit details
    Browse the repository at this point in the history

  4. [SwitchBase] Rename inputType to type

    @oliviertassinari
    oliviertassinari committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    bc5f78f View commit details
    Browse the repository at this point in the history

  5. document the id

    @oliviertassinari
    oliviertassinari committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    f64557c View commit details
    Browse the repository at this point in the history