Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add most Dialog TypeScript demos #15271

Merged
merged 7 commits into from Apr 10, 2019
Merged

[docs] Add most Dialog TypeScript demos #15271

merged 7 commits into from Apr 10, 2019

Conversation

sperry94
Copy link
Contributor

@sperry94 sperry94 commented Apr 9, 2019

This PR adds most TS demos for the Dialog component

This was referenced Apr 9, 2019
Merged
Merged
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 9, 2019 •
edited

No bundle size changes comparing 1d32f23...7da0a88

Generated by 🚫 dangerJS against 7da0a88

@eps1lon eps1lon self-requested a review April 9, 2019 08:06
@eps1lon eps1lon added docs Improvements or additions to the documentation typescript labels Apr 9, 2019
@eps1lon eps1lon changed the title [docs]: Adding most Dialog Typescript demos [docs] Add most Dialog TypeScript demos Apr 9, 2019
@eps1lon eps1lon mentioned this pull request Apr 9, 2019
Closed
@eps1lon eps1lon added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 9, 2019
eps1lon
eps1lon requested changes Apr 9, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Could you base this on #15276 since this is improving the types that are used in ResponsiveDialog.tsx?

@sperry94
Copy link
Contributor Author

sperry94 commented Apr 9, 2019

Nicely done. Could you base this on #15276 since this is improving the types that are used in ResponsiveDialog.tsx?

@eps1lon Sure I can do that! Do you mean rebasing the sperry94:dialogs-ts-docs branch onto the eps1lon:fix/core/withMobileDialog/types branch?

@eps1lon
Copy link
Member

eps1lon commented Apr 9, 2019

Nicely done. Could you base this on #15276 since this is improving the types that are used in ResponsiveDialog.tsx?

@eps1lon Sure I can do that! Do you mean rebasing the sperry94:dialogs-ts-docs branch onto the eps1lon:fix/core/withMobileDialog/types branch?

I just merged it. You can rebase onto next now.

@sperry94
Copy link
Contributor Author

sperry94 commented Apr 9, 2019

Nicely done. Could you base this on #15276 since this is improving the types that are used in ResponsiveDialog.tsx?

@eps1lon Sure I can do that! Do you mean rebasing the sperry94:dialogs-ts-docs branch onto the eps1lon:fix/core/withMobileDialog/types branch?

I just merged it. You can rebase onto next now.

Rebased!

@eps1lon eps1lon removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 9, 2019
eps1lon added a commit that referenced this pull request Apr 10, 2019
@sperry94 @eps1lon
[DialogContent] Add divider prop type for TypeScript (#15273)
3b084f6 
This PR adds the TS demo for ConfirmationDialog. This was separated from the main PR (#15271) because more changes were required for this demo.

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@eps1lon eps1lon merged commit dfea5ba into mui:next Apr 10, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 10, 2019

@sperry94 Much appreciated. Thanks.

eps1lon added a commit that referenced this pull request Apr 11, 2019
@sperry94 @eps1lon
[Select] Fix incorrect event.target type in onChange (#15272)
c5700e0 
This PR adds the TS demo for MaxWidthDialog. It was separated from the other PR (#15271) since more changes were involved.

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sperry94 @mui-pr-bot @eps1lon @oliviertassinari