-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add most Dialog TypeScript demos #15271
Conversation
No bundle size changes comparing 1d32f23...7da0a88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. Could you base this on #15276 since this is improving the types that are used in ResponsiveDialog.tsx
?
I just merged it. You can rebase onto |
Rebased! |
This PR adds the TS demo for ConfirmationDialog. This was separated from the main PR (#15271) because more changes were required for this demo. Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@sperry94 Much appreciated. Thanks. |
This PR adds the TS demo for MaxWidthDialog. It was separated from the other PR (#15271) since more changes were involved. Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
This PR adds most TS demos for the Dialog component