[Slide] Remove the transform property once open #16281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Details of bundle changes.Comparing: a7d25a2...cb01ba7
|
oliviertassinari
changed the title
oliviertassinari
approved these changes
Jun 19, 2019
|
Did some quick manual testing with IE11 with Slide and Drawer demos and everything seemed fine. @gijsbotje It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
|
@oliviertassinari @eps1lon Thanks for the fast response! and actually merging it 😄 |
1 task
2 tasks
oliviertassinari
added
component: transitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16219
Elements that are positioned fixed inside a drawer and also transformed are wrongly positioned. You would expect the elements to positioned fixed to the top left of the window, though because of the parent containing
position: fixed;they are positioned relative to this parent.The mentioned issue provides example where the draggable elements of rbd are positioned off screen due to this issue.
these changes reset of the transform value to
nonewhen the element is visible. Because of IE11 not playing nicely with just that change it was necessary to change the starting point from100vhtowindow.innerWidth.