Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Drop support for non-ref-forwarding class components #21811

Merged
merged 5 commits into from Jul 17, 2020
Merged

[core] Drop support for non-ref-forwarding class components #21811

merged 5 commits into from Jul 17, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 16, 2020 •
edited

Class components not forwarding their ref to the underlying DOM (or host) component are no longer supported. If you were using unstable_createStrictModeTheme or didn't see any StrictMode warnings regarding findDOMNode then this change is not breaking.

unstable_createStrictModeTheme stays for now as a no-op in case we need it again during v5 development.

Has a deprecation in place (via StrictMode).

TODO:

  • [ ] revisit StrictModeViolation comments Updating these in a follow-up

@eps1lon eps1lon added breaking change package: lab Specific to @mui/lab package: material-ui Specific to @mui/material labels Jul 16, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 16, 2020 •
edited

@material-ui/core: parsed: -0.39% 😍, gzip: -0.61% 😍
@material-ui/lab: parsed: -0.30% 😍, gzip: -0.51% 😍

Details of bundle changes

Generated by 🚫 dangerJS against f000950

@github-actions github-actions bot mentioned this pull request Jul 16, 2020
Closed
@eps1lon eps1lon marked this pull request as ready for review July 16, 2020 15:04
@eps1lon eps1lon marked this pull request as draft July 16, 2020 15:31
@eps1lon eps1lon marked this pull request as ready for review July 16, 2020 16:11
oliviertassinari
oliviertassinari reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels great to get ride of this logic

docs/src/pages/guides/migration-v4/migration-v4.md Outdated Show resolved Hide resolved
packages/material-ui/src/Collapse/Collapse.test.js Outdated Show resolved Hide resolved
packages/material-ui/src/utils/useIsFocusVisible.js Outdated Show resolved Hide resolved
@eps1lon eps1lon merged commit 750cdfe into mui:next Jul 17, 2020
@eps1lon eps1lon deleted the feat/findDOMNode-removal branch July 17, 2020 09:32
@eps1lon eps1lon mentioned this pull request Jul 20, 2020
Closed
7 tasks
@oliviertassinari oliviertassinari mentioned this pull request Jul 20, 2020
Closed
2 tasks
@eps1lon eps1lon mentioned this pull request Jul 22, 2020
Merged
@eps1lon eps1lon added this to the v5 milestone Aug 4, 2020
@eps1lon eps1lon mentioned this pull request Aug 5, 2020
Closed
42 tasks
@Jack-Works Jack-Works mentioned this pull request Sep 4, 2020
Merged
@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes and removed package: material-ui Specific to @mui/material package: lab Specific to @mui/lab labels Jan 9, 2021
@eps1lon eps1lon added package: material-ui Specific to @mui/material and removed core Infrastructure work going on behind the scenes labels Jan 11, 2021
@michaldudak michaldudak mentioned this pull request Nov 17, 2021
Closed
2 tasks
@michaldudak michaldudak mentioned this pull request Jun 28, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
breaking change package: material-ui Specific to @mui/material
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eps1lon @mui-pr-bot @oliviertassinari @joshwooding