[system] Fix transform not firing when theme provided #24010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed the bug where transform was not fired if a theme was provided. Similarly, added tests to test this. Tests were provided from the changes in this thread (https://github.com/akomm/material-ui/blob/a4a394ff5420d29311ce1edef2bf20b51b507954/packages/material-ui-system/src/style.test.js) And the change to style.js was provided in the issue discussion.
mnajdova
reviewed
Dec 14, 2020
mnajdova
reviewed
Dec 14, 2020
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
|
Thank you! All my tests are passing except Vercel (which I think is a permission based check?). This will also be my very first open source contribution ever! I'm very excited. =) |
|
Completed! All tests except Vercel pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug where transform was not fired if a theme was provided. Similarly, added tests to test this. Tests were provided from the changes in this thread (https://github.com/akomm/material-ui/blob/a4a394ff5420d29311ce1edef2bf20b51b507954/packages/material-ui-system/src/style.test.js)
And the change to style.js was provided in the issue discussion.
Fixes #23496