Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Fix transform not firing when theme provided #24010

Merged
merged 5 commits into from
Dec 14, 2020
Merged

[system] Fix transform not firing when theme provided #24010

merged 5 commits into from
Dec 14, 2020

Commits on Dec 14, 2020

  1. fixed/added tests for transform w. theme provided 

    fixed the bug where transform was not fired if a theme was provided. Similarly, added tests to test this. Tests were provided from the changes in this thread (https://github.com/akomm/material-ui/blob/a4a394ff5420d29311ce1edef2bf20b51b507954/packages/material-ui-system/src/style.test.js)

And the change to style.js was provided in the issue discussion.
    @ZovcIfzm
    ZovcIfzm committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    65f341b View commit details
    Browse the repository at this point in the history

  2. Update packages/material-ui-system/src/style.test.js 

    Co-authored-by: Marija Najdova <mnajdova@gmail.com>
    @ZovcIfzm @mnajdova
    ZovcIfzm and mnajdova committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    2ba9c13 View commit details
    Browse the repository at this point in the history

  3. Update packages/material-ui-system/src/style.test.js 

    Co-authored-by: Marija Najdova <mnajdova@gmail.com>
    @ZovcIfzm @mnajdova
    ZovcIfzm and mnajdova committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    68c604c View commit details
    Browse the repository at this point in the history

  4. ran prettier- fixed styling

    @ZovcIfzm
    ZovcIfzm committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    d3edec9 View commit details
    Browse the repository at this point in the history

  5. moved const inside

    @ZovcIfzm
    ZovcIfzm committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    34295a2 View commit details
    Browse the repository at this point in the history