-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppBar] Migrate to emotion #24439
[AppBar] Migrate to emotion #24439
Conversation
@material-ui/core: parsed: +0.17% , gzip: +0.18% |
@mnajdova can you help me with this it tell me that I have to run yarn proptypes? but it removes className. |
elevation={4} | ||
className={clsx( | ||
classes.root, | ||
classes[`position${capitalize(position)}`], | ||
classes[`color${capitalize(color)}`], | ||
{ | ||
'mui-fixed': position === 'fixed', // Useful for the Dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may be able to get rid of this now that we have utility classes, but let's keep it as is to keep the PR focused to the migraiton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mui-fixed probably is used even docs talks about it https://next.material-ui.com/getting-started/faq/#why-do-the-fixed-positioned-elements-move-when-a-modal-is-opened
docs/pages/api-docs/app-bar.json
Outdated
@@ -6,16 +6,15 @@ | |||
"type": { | |||
"name": "enum", | |||
"description": "'default'<br>| 'inherit'<br>| 'primary'<br>| 'secondary'<br>| 'transparent'" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully the changes on https://github.com/mui-org/material-ui/pull/24439/files#r558589220 will help us fix these regressions
Well, some dark magic worked after moving all properties as separate variable :D |
Ok, one done more to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks!
One of #24405