Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkbox] Migrate to emotion #24702

Merged
merged 10 commits into from
Feb 9, 2021
Merged

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 30, 2021

#24405

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 30, 2021

@material-ui/core: parsed: +0.07% , gzip: +0.03%

Details of bundle changes

Generated by 🚫 dangerJS against b13b4e6

@natac13
Copy link
Contributor Author

natac13 commented Jan 30, 2021

I was curious if the indeterminate class is really a Pseudo class as it's name is differenent than other Pseudo classes

https://next--material-ui.netlify.app/api/checkbox/#css

https://github.com/mui-org/material-ui/pull/24702/files#diff-648f4c502fda26c52fcb02385dcdf3c032b5aea842cfd1df85ab673f5058d239R27

@oliviertassinari oliviertassinari added the component: checkbox This is the name of the generic UI component, not the React module! label Jan 30, 2021
@natac13
Copy link
Contributor Author

natac13 commented Jan 30, 2021

I think the failing test just need to be re-run.

@vicasas
Copy link
Member

vicasas commented Jan 30, 2021

Maybe for the first failed test you are missing themeVariants in the test file skip. I previously had a similar error and solved it using this.

@natac13
Copy link
Contributor Author

natac13 commented Jan 30, 2021

I do not think these test have to do with the changes I have made. I could be wrong. But they have been failing intermittently

Ill add it and find out though thanks for the help.
Update:
Just checked again and I do not see those errors.

@oliviertassinari
Copy link
Member

@natac13 We could in theory treat indeterminate as the other pseudo-classes. However, the LinearProgress already uses this name. It would create a conflict. For now, I think that we can focus on the migration :)

@oliviertassinari oliviertassinari merged commit 5f4b5cd into mui:next Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: checkbox This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants