Use preventDefault in _onExpandable handler. Fixes #2484 #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,8 @@ const Card = React.createClass({ | |||
| style: React.PropTypes.object, | |||
| }, | |||
|
|
|||
| _onExpandable() { | |||
| _onExpandable(e) { | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
Can we call it event? I think that it's better to be explicit.
|
@neverfox That sounds like an excellent idea. |
On some touch devices and in certain contexts, a touch event can trigger a second mouse event, causing expandable cards to close as soon as they open. Follows advice from http://www.html5rocks.com/en/mobile/touchandmouse/ to "use preventDefault() inside touch event handlers, so the default mouse-emulation handling doesn’t occur." Even though this can prevent "other default browser behavior (like scrolling)", this shouldn't be a danger in the specific context of this handler. Rename e to event in _onExpandable
neverfox
force-pushed
the
pull-request/card-prevent-default
branch
from
87b6f0b
to
9bb9819
Compare
|
@oliviertassinari Done! |
|
@neverfox Thanks a lot 👍 👍 |
alitaheri
added a commit
that referenced
this pull request
Dec 13, 2015
Use preventDefault in _onExpandable handler. Fixes #2484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some touch devices and in certain contexts, a touch event can trigger a second mouse event, causing expandable cards to close as soon as they open. Follows advice from http://www.html5rocks.com/en/mobile/touchandmouse/ to "use preventDefault() inside touch event handlers, so the default mouse-emulation handling doesn’t occur." Even though this can prevent "other default browser behavior (like scrolling)", this shouldn't be a danger in the specific context of this handler.