Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use preventDefault in _onExpandable handler. Fixes #2484 #2495

Merged
merged 1 commit into from
Dec 13, 2015
Merged

Use preventDefault in _onExpandable handler. Fixes #2484 #2495

merged 1 commit into from
Dec 13, 2015

Commits on Dec 13, 2015

  1. Use preventDefault in _onExpandable handler. Fixes mui#2484 

    On some touch devices and in certain contexts, a touch event can trigger a second mouse event, causing expandable cards to close as soon as they open. Follows advice from http://www.html5rocks.com/en/mobile/touchandmouse/ to "use preventDefault() inside touch event handlers, so the default mouse-emulation handling doesn’t occur." Even though this can prevent "other default browser behavior (like scrolling)", this shouldn't be a danger in the specific context of this handler.

Rename e to event in _onExpandable
    @neverfox
    neverfox committed Dec 13, 2015
    Configuration menu
    Copy the full SHA
    9bb9819 View commit details
    Browse the repository at this point in the history