New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppBar] Fix type support of overridable component #25456
[AppBar] Fix type support of overridable component #25456
Conversation
Removing the |
I just started to figure out how it works. Please help me to understand why |
I had a look. It seems that the generation scripts were failing because the types are wrong. I have pushed a commit to follow the other components in the codebase. Not sure if it's enough but it seems to work. I'm moving to a different effort. A thorough review would be great. |
I have rebased to leverage the latest fix Sebastian did. |
I'm moving forward with it as the issue we asked the help of Sebastian for is no longer reproducing. We manage to get away without by using the standard way the component types in the rest of the codebase. We also have new test cases in case we need to further iterate. |
@oliviertassinari Sorry for not participating anymore.. Too many new things for me. |
Added the OverridableComponent to AppBar.
Can somebody help me to understand why proptypes generator insistently removes
component
prop and@default
annotation from js file? It's not easy to understand howtypescript-to-proptypes
andgenerateProptypes.ts
works, so I gave up.