[Card] Add component prop support #25537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silver-snoopy
changed the title
silver-snoopy
changed the title
oliviertassinari
added
component: card
|
Waiting for #25456 to be resolved first |
oliviertassinari
approved these changes
Mar 28, 2021
oliviertassinari
force-pushed
the
cardComponentPropSupport
branch
from
f367267
to
8e407aa
Compare
|
@silver-snoopy Thanks. I think that we can bypass the test-case phase because this a pattern we try all the components to follow. I might be overkill to add a test for each. |
This was referenced Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe
This PR aims to solve the following Closes #25513
Thanks for the proposed solution @oliviertassinari.
I have renamed the Card test file to use tsx and we can see the supported component prop