Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timeline] Add support for position override on items #25974

Merged
merged 7 commits into from
Apr 29, 2021
Merged

[Timeline] Add support for position override on items #25974

merged 7 commits into from
Apr 29, 2021

Conversation

simonecervini
Copy link
Contributor

@simonecervini simonecervini commented Apr 25, 2021

Breaking changes

  • [Timeline] Rename the align prop to position to reduce confusion.

    -<Timeline align="alternate">
    +<Timeline position="alternate">
    -<Timeline align="left">
    +<Timeline position="right">
    -<Timeline align="right">
    +<Timeline position="left">

A proof of concept of the proposed solution from #25862

Closes #25862

Preview: https://deploy-preview-25974--material-ui.netlify.app/components/timeline/#left-positioned-timeline

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 25, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 1d7ea4e

@oliviertassinari oliviertassinari added the component: timeline This is the name of the generic UI component, not the React module! label Apr 25, 2021
@oliviertassinari oliviertassinari changed the title [Timeline] Add support for align override on items #25862 [Timeline] Add support for align override on items Apr 25, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2021
@mnajdova mnajdova changed the title [Timeline] Add support for align override on items [Timeline] Add support for position override on items Apr 28, 2021
simonecervini and others added 2 commits April 28, 2021 19:56
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mnajdova mnajdova merged commit c7da2a5 into mui:next Apr 29, 2021
eps1lon pushed a commit to siriwatknp/material-ui that referenced this pull request Apr 29, 2021
siriwatknp added a commit that referenced this pull request May 12, 2021
* migrate to emotion

* make styleProps optional

* remove lint and add fn name

* use yearButton from styles

* revert types

* [docs] Document all the colors available (#26015)

* [Timeline] Add support for position override on items (#25974)

* [core] Remove deprecated innerRef prop (#26028)

[core] Remove deprecated innerRef prop (#26028)

* [theme] Rename `createMuiTheme` to `createTheme` (#25992)

* [pickers] Remove redundant aria-hidden (#26014)

* [internal][pickers] Remove unused styles (#26023)

* [pickers] Toggle mobile keyboard view in the same commit as the view changes (#26017)

* [DateRangePicker] Fix not being opened on click (#26016)

* Inline classes

* type -> interface

* sort asc

* default props are private

* remove uneccesary type casting

* follow convention

* trigger pipeline

Co-authored-by: Anshuman Pandey <54475686+anshuman9999@users.noreply.github.com>
Co-authored-by: simonecervini <69400730+simonecervini@users.noreply.github.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: timeline This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Timeline] Add support for align override on items
4 participants