Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Remove redundant aria-hidden #26014

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 28, 2021

aria-hidden was applied to elements which should have visibility: hidden. These elements are already excluded from the a11y tree. If they are visible then they should be part of the a11y tree.

@eps1lon eps1lon added the component: pickers This is the name of the generic UI component, not the React module! label Apr 28, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 28, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 3dd89cf

@eps1lon eps1lon added the accessibility a11y label Apr 28, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon eps1lon merged commit d8d290b into mui:next Apr 29, 2021
@eps1lon eps1lon deleted the feat/pickers/redundant-aria-hidden branch April 29, 2021 07:43
eps1lon added a commit to siriwatknp/material-ui that referenced this pull request Apr 29, 2021
siriwatknp added a commit that referenced this pull request May 12, 2021
* migrate to emotion

* make styleProps optional

* remove lint and add fn name

* use yearButton from styles

* revert types

* [docs] Document all the colors available (#26015)

* [Timeline] Add support for position override on items (#25974)

* [core] Remove deprecated innerRef prop (#26028)

[core] Remove deprecated innerRef prop (#26028)

* [theme] Rename `createMuiTheme` to `createTheme` (#25992)

* [pickers] Remove redundant aria-hidden (#26014)

* [internal][pickers] Remove unused styles (#26023)

* [pickers] Toggle mobile keyboard view in the same commit as the view changes (#26017)

* [DateRangePicker] Fix not being opened on click (#26016)

* Inline classes

* type -> interface

* sort asc

* default props are private

* remove uneccesary type casting

* follow convention

* trigger pipeline

Co-authored-by: Anshuman Pandey <54475686+anshuman9999@users.noreply.github.com>
Co-authored-by: simonecervini <69400730+simonecervini@users.noreply.github.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants