[pickers] Rely on native behavior for disabled/readOnly behavior #26055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
accessibility
github-actions
bot
added
PR: out-of-date
eps1lon
force-pushed
the
feat/pickers/disabled
branch
from
ee27931
to
77685f4
Compare
oliviertassinari
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button for opening the picker is now
:disabledwhen the picker hasreadOnly={true}. Clicking didn't have any effect so we might as well indicate that. This produces visual differences reported by argos. They are expected but I'll let reviewers approve them.I've also moved checking against
readOnlyanddisabledto their respective callsites. This simplifiesusePickerState. If this causes breakage too often we can revert. But right now we only needopenPickerin two places.Manual testing:
https://deploy-preview-26055--material-ui.netlify.app/components/date-picker/#form-props
https://deploy-preview-26055--material-ui.netlify.app/components/date-range-picker/#form-props