Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Document readonly/disabled pickers #26056

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

@eps1lon eps1lon added docs Improvements or additions to the documentation test component: pickers This is the name of the generic UI component, not the React module! labels Apr 29, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 29, 2021

No bundle size changes

Generated by 🚫 dangerJS against 406ce20

@eps1lon eps1lon force-pushed the chore/pickers/readonly-disabled-baseline branch from 412f457 to 406ce20 Compare April 29, 2021 15:11
@eps1lon eps1lon marked this pull request as ready for review April 29, 2021 19:44
@eps1lon eps1lon merged commit 7fff60a into mui:next Apr 30, 2021
@eps1lon eps1lon deleted the chore/pickers/readonly-disabled-baseline branch April 30, 2021 07:55

return (
<LocalizationProvider dateAdapter={AdapterDateFns}>
<div style={{ width: 300 }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using a <Stack> to add spacing between the items? It could display better:

Screenshot 2021-04-30 at 11 23 04

The other demos seem to use margin="normal" on text field, I guess it's an alternative.

Copy link
Member Author

@eps1lon eps1lon Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine without introducing a new component. Using other components isn't free. When learning about a component I now have to also learn about this other component. And the Stack seems not relevant to this component.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine without introducing a new component.

So, you mean using margin="normal"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants