[internal][pickers] Move validation from config to module #26074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
performance
component: pickers
|
@material-ui/lab: parsed: -0.11% 😍, gzip: -0.22% 😍 |
eps1lon
force-pushed
the
chore/pickers/makeValidation
branch
from
a732478
to
67976ee
Compare
eps1lon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a higher-order hooks that is passed around as a config object we can compose hooks and create a module for these hooks.
Composing hooks is what we usually do and I see not benefit of higher-order hooks other than saving dependency argument. I'd be very surprised if that had any perf impact.
Using a module instead of a config object allows for better dead-code elimination via tree-shaking.