Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Utilize CSS.supports in SliderUnstyled component #27724

Merged
merged 4 commits into from Aug 16, 2021
Merged

[core] Utilize CSS.supports in SliderUnstyled component #27724

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c656d1
Utilize CSS.supports
DanailH Aug 13, 2021
04824ed
Update packages/material-ui-unstyled/src/SliderUnstyled/SliderUnstyle…
DanailH Aug 13, 2021
299ebbd
Update packages/material-ui-unstyled/src/SliderUnstyled/SliderUnstyle…
DanailH Aug 13, 2021
779e4ff
fix `CSS.supports` being overridden
eps1lon Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/material-ui-unstyled/src/SliderUnstyled/SliderUnstyled.js
View file
Open in desktop
Expand Up @@ -140,14 +140,18 @@ const Identity = (x) => x;
// Safari, on iOS, supports touch action since v13.
// Over 80% of the iOS phones are compatible
// in August 2020.
// Utilizing the CSS.supports method to check if touch-action is supported.
// Since CSS.supports is supported on all but Edge@12 and IE and touch-action
// is supported on both Edge@12 and IE if CSS.supports is not available that means that
// touch-action will be supported
let cachedSupportsTouchActionNone;
function doesSupportTouchActionNone() {
if (cachedSupportsTouchActionNone === undefined) {
const element = document.createElement('div');
element.style.touchAction = 'none';
document.body.appendChild(element);
cachedSupportsTouchActionNone = window.getComputedStyle(element).touchAction === 'none';
element.parentElement.removeChild(element);
if (typeof CSS !== 'undefined' && typeof CSS.supports === 'function') {
cachedSupportsTouchActionNone = CSS.supports('touch-action', 'none');
}

cachedSupportsTouchActionNone = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set this in an else branch. Otherwise it always overrides the actual value.

Good news is that we can actually test this behavior in browserstack.

}
return cachedSupportsTouchActionNone;
}
Expand Down