[core] Utilize CSS.supports in SliderUnstyled component
#27724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
requested changes
Aug 13, 2021
packages/material-ui-unstyled/src/SliderUnstyled/SliderUnstyled.js
Outdated
Show resolved
Hide resolved
packages/material-ui-unstyled/src/SliderUnstyled/SliderUnstyled.js
Outdated
Show resolved
Hide resolved
…d.js Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
…d.js Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
eps1lon
approved these changes
Aug 13, 2021
|
If it goes in, it would be great to update https://github.com/mui-org/material-ui-x/blob/3d30ee895675b47db158e0e4543227e8508a4634/packages/grid/_modules_/grid/hooks/features/columnResize/useGridColumnResize.tsx#L31 too (mui-x) |
eps1lon
reviewed
Aug 14, 2021
| cachedSupportsTouchActionNone = CSS.supports('touch-action', 'none'); | ||
| } | ||
|
|
||
| cachedSupportsTouchActionNone = true; |
There was a problem hiding this comment.
We need to set this in an else branch. Otherwise it always overrides the actual value.
Good news is that we can actually test this behavior in browserstack.
eps1lon
approved these changes
Aug 14, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize the
CSS.supportsmethod inSliderUnstyledcomponent to check iftouch-actionis supported.