Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix href propagation to anchor #27937

Closed
wants to merge 1 commit into from
Closed

[docs] Fix href propagation to anchor #27937

wants to merge 1 commit into from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 24, 2021 •
edited

Before

Due to a change in rebranding

// docs/src/mobules/components/Link.tsx
-<a>...</a>

+const Anchor = styled('a')({}) // to enable `sx` from outside
+<Anchor>...</Anchor>

This change cause Nextjs Link to not propagate href since <Anchor> is a react component. When clicking on the links in docs, will get this error.

Screen Shot 2564-08-24 at 16 55 53

Screen Shot 2564-08-24 at 17 00 34

After

Screen Shot 2564-08-24 at 17 02 14

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Aug 24, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 24, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 909d429

mnajdova
mnajdova approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@eps1lon
Copy link
Member

eps1lon commented Aug 24, 2021

Duplicate of #27936

@eps1lon eps1lon marked this as a duplicate of #27936 Aug 24, 2021
@eps1lon eps1lon closed this Aug 24, 2021
@github-actions github-actions bot added the duplicate This issue or pull request already exists label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siriwatknp @mui-pr-bot @eps1lon @mnajdova