Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update CI bucket #30080

Merged
merged 6 commits into from
Dec 9, 2021
Merged

[ci] Update CI bucket #30080

merged 6 commits into from
Dec 9, 2021

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 6, 2021

We're closing the account under which the bucket was created and ownership of buckets can't be transferred. So we're recreating it.

On the new bucket I'm also using bucket policies to control object access instead of putting object ACL.

will have to update the dashboard as well: https://github.com/mui-org/mui-contributor-dashboard/blob/9010a86de7aee24aabc2dbb0ef421c8f6a267395/src/pages/SizeComparison.tsx#L150

To Do after merging:

  • Update AWS_ACCESS_KEY_ID_ARTIFACTS and AWS_SECRET_ACCESS_KEY_ARTIFACTS in circle env vars to the new credentials for the circleci user
  • copy old bucket's files (aws s3 cp s3://mui-org-material-ui/artifacts/master/ s3://mui-org-ci/artifacts/master/ --recursive)
  • Open a follow up PR to replace the ..._TMP vars in the circleci config with the original ones and remove the bucket fallback
  • remove the _TMP vars from circleci
  • close the old account? (how much will it cost to delete the bucket?)

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 6, 2021

No bundle size changes

Generated by 🚫 dangerJS against f23f203

@Janpot Janpot changed the title Update CI bucket [ci] Update CI bucket Dec 6, 2021
@Janpot Janpot marked this pull request as ready for review December 6, 2021 17:33
@Janpot Janpot requested a review from eps1lon December 6, 2021 17:34
@eps1lon eps1lon removed their request for review December 6, 2021 17:37
@mui mui deleted a comment from eps1lon Dec 6, 2021
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the PR and the follow-up plans look sensible to me.

@Janpot Janpot merged commit 8a7e545 into mui:master Dec 9, 2021
@Janpot Janpot deleted the update-ci-bucket branch December 9, 2021 17:07
@zannager zannager added the docs Improvements or additions to the documentation label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants