Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix size:snapshot for mui-material-next and mui-joy #30106

Merged
merged 2 commits into from
Dec 8, 2021
Merged

[core] Fix size:snapshot for mui-material-next and mui-joy #30106

merged 2 commits into from
Dec 8, 2021

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 8, 2021 •
edited

While working on #30080, I noticed this in the build for yarn size:snapshot

...
Compiling 210-220: "SwitchUnstyled", "TabPanelUnstyled", "TabUnstyled", "TablePaginationUnstyled", "TabsListUnstyled", "TabsUnstyled", "TextareaAutosize", "Unstable_TrapFocus", "@material-ui/utils", "@material-ui/core.legacy"
Compiling 220-230: "undefined", "undefined", "undefined", "undefined", "undefined", "undefined", "undefined", "undefined", "undefined", "undefined"
Done in 231.85s.
CircleCI received exit code 0

To do

  • It doesn't look like this creates unique entries. Will have to look into that I namespaced them using their package name

Screenshot 2021-12-08 at 10 26 42

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 8, 2021 •
edited

Details of bundle changes

@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against 89d6707

siriwatknp
siriwatknp approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Nice!

@Janpot Janpot merged commit 19ed8d8 into mui:master Dec 8, 2021
@Janpot Janpot deleted the size-comparisons branch December 8, 2021 12:57
@oliviertassinari oliviertassinari changed the title [fix] size:snapshot for mui-material-next and mui-joy components [core] Fix size:snapshot for mui-material-next and mui-joy Dec 8, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes performance labels Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Janpot @mui-pr-bot @siriwatknp @oliviertassinari