Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SliderUnstyled] Add useSlider hook and polish #30094

Merged
merged 23 commits into from
Jan 11, 2022
Merged

[SliderUnstyled] Add useSlider hook and polish #30094

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6814667
[SliderUnstyled] Update components & componentsProps
mnajdova Dec 7, 2021
96c3dff
[useSlider] Add hook (WIP)
mnajdova Dec 7, 2021
f47b01c
proptypes & docs:api
mnajdova Dec 7, 2021
086aa86
Improve logic for forwarding props
mnajdova Dec 8, 2021
6f925a1
Various fixes
mnajdova Dec 8, 2021
d3c0033
prettier
mnajdova Dec 8, 2021
26287cc
Update test/utils/describeConformanceUnstyled.tsx
mnajdova Dec 8, 2021
bd62bb2
Run prettier
hbjORbj Dec 8, 2021
57ff661
Merge branch 'master' into base/update-slider-unstyled
mnajdova Dec 10, 2021
d7607ed
add handlers in the callback for the props
mnajdova Dec 10, 2021
625e62d
Merge branch 'base/update-slider-unstyled' of https://github.com/mnaj…
mnajdova Dec 10, 2021
d81b1c8
Remove unused imports
mnajdova Dec 10, 2021
662f1cd
Michal's review
mnajdova Dec 17, 2021
cc5e511
Merge branch 'master' into base/update-slider-unstyled
mnajdova Dec 17, 2021
80fd507
Update the conformance test, remove getTrackProps usages
mnajdova Dec 17, 2021
967978a
Spread trackStyle
mnajdova Dec 17, 2021
3cf779a
Various fixes
mnajdova Dec 17, 2021
97ca246
Merge branch 'master' into base/update-slider-unstyled
mnajdova Dec 21, 2021
52e5a7c
Address review comments
mnajdova Dec 21, 2021
afac9ca
Improve onMouseDown handling
mnajdova Dec 22, 2021
9f83569
Refactor event handlers
mnajdova Dec 27, 2021
ebab422
Merge branch 'master' into base/update-slider-unstyled
mnajdova Jan 11, 2022
d556c51
Fixes after merge
mnajdova Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/pages/api-docs/slider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
},
"default": "'primary'"
},
"component": { "type": { "name": "elementType" } },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component prop should remain in the docs, shouldn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's removed because the prop is available in the unstyled component. Will double check

"components": {
"type": {
"name": "shape",
Expand Down
3 changes: 1 addition & 2 deletions docs/translations/api-docs/slider/slider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"track": "The track presentation:<br>- <code>normal</code> the track will render a bar representing the slider value. - <code>inverted</code> the track will render a bar representing the remaining slider value. - <code>false</code> the track will render without a bar.",
"value": "The value of the slider. For ranged sliders, provide an array with two values.",
"valueLabelDisplay": "Controls when the value label is displayed:<br>- <code>auto</code> the value label will display when the thumb is hovered or focused. - <code>on</code> will display persistently. - <code>off</code> will never display.",
"valueLabelFormat": "The format function the value label&#39;s value.<br>When a function is provided, it should have the following signature:<br>- {number} value The value label&#39;s value to format - {number} index The value label&#39;s index to format",
"component": "The component used for the root node. Either a string to use a HTML element or a component."
"valueLabelFormat": "The format function the value label&#39;s value.<br>When a function is provided, it should have the following signature:<br>- {number} value The value label&#39;s value to format - {number} index The value label&#39;s index to format"
},
"classDescriptions": {
"root": { "description": "Class name applied to the root element." },
Expand Down
12 changes: 6 additions & 6 deletions packages/mui-base/src/SliderUnstyled/SliderUnstyled.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ export interface SliderUnstyledTypeMap<P = {}, D extends React.ElementType = 'sp
* @default {}
*/
componentsProps?: {
root?: React.HTMLAttributes<HTMLSpanElement> & SliderUnstyledComponentsPropsOverrides;
track?: React.HTMLAttributes<HTMLSpanElement> & SliderUnstyledComponentsPropsOverrides;
rail?: React.HTMLAttributes<HTMLSpanElement> & SliderUnstyledComponentsPropsOverrides;
thumb?: React.HTMLAttributes<HTMLSpanElement> & SliderUnstyledComponentsPropsOverrides;
mark?: React.HTMLAttributes<HTMLSpanElement> & SliderUnstyledComponentsPropsOverrides;
markLabel?: React.HTMLAttributes<HTMLSpanElement> & SliderUnstyledComponentsPropsOverrides;
root?: React.ComponentPropsWithRef<'span'> & SliderUnstyledComponentsPropsOverrides;
track?: React.ComponentPropsWithRef<'span'> & SliderUnstyledComponentsPropsOverrides;
rail?: React.ComponentPropsWithRef<'span'> & SliderUnstyledComponentsPropsOverrides;
thumb?: React.ComponentPropsWithRef<'span'> & SliderUnstyledComponentsPropsOverrides;
mark?: React.ComponentPropsWithRef<'span'> & SliderUnstyledComponentsPropsOverrides;
markLabel?: React.ComponentPropsWithRef<'span'> & SliderUnstyledComponentsPropsOverrides;
valueLabel?: React.ComponentPropsWithRef<typeof SliderValueLabelUnstyled> &
SliderUnstyledComponentsPropsOverrides;
};
Expand Down